Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Pylint on some celery-related files #8765

Merged
merged 2 commits into from
Dec 8, 2019

Conversation

willbarrett
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Re-enables pylint for a couple of files related to Celery.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@john-bodley @dpgaspar

@codecov-io
Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #8765 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8765   +/-   ##
=======================================
  Coverage   65.83%   65.83%           
=======================================
  Files         482      482           
  Lines       24155    24155           
  Branches     2770     2770           
=======================================
  Hits        15903    15903           
  Misses       8074     8074           
  Partials      178      178
Impacted Files Coverage Δ
superset/tasks/celery_app.py 0% <ø> (ø) ⬆️
superset/tasks/schedules.py 79.89% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bdf764...6f59cd6. Read the comment docs.

@mistercrunch mistercrunch merged commit 9c2b27f into apache:master Dec 8, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants