Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-15] Fix ISO 8601 datetime matching/labeling in the DateFilterControl #8494

Conversation

john-bodley
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This PR replaces the ISO 8601 regex for the DateFilterControl with moment's parsing as it's viable for one to simply defined a date (or similar).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

Screen Shot 2019-11-01 at 11 46 35 AM

AFTER

Screen Shot 2019-11-01 at 11 45 44 AM

TEST PLAN

Manually tested.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

to: @etr2460 @graceguo-supercat

@codecov-io
Copy link

codecov-io commented Nov 1, 2019

Codecov Report

Merging #8494 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8494      +/-   ##
==========================================
- Coverage   66.61%   66.61%   -0.01%     
==========================================
  Files         449      449              
  Lines       22610    22609       -1     
  Branches     2367     2367              
==========================================
- Hits        15061    15060       -1     
  Misses       7411     7411              
  Partials      138      138
Impacted Files Coverage Δ
.../explore/components/controls/DateFilterControl.jsx 39.62% <100%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 554a6d8...7ea6076. Read the comment docs.

@john-bodley john-bodley changed the title [SIP-15] Updating ISO 8601 regex match to make time optional [SIP-15] Fix ISO 8601 datetime matching/labeling in the DateFilterControl Nov 1, 2019
@john-bodley john-bodley merged commit fda2333 into apache:master Nov 2, 2019
@john-bodley john-bodley deleted the john-bodley--sip-15-fix-date-filter-control branch November 2, 2019 00:44
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Nov 2, 2019
@dpgaspar dpgaspar added v0.35 and removed v0.35 labels Dec 20, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants