Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing typo. #8487

Merged
Merged

Conversation

MarcusSorealheis
Copy link
Contributor

@MarcusSorealheis MarcusSorealheis commented Oct 30, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Simple change to punctuation error I ran into while consulting for one of our projects.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #8487 into master will decrease coverage by 4.93%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8487      +/-   ##
==========================================
- Coverage   71.47%   66.53%   -4.94%     
==========================================
  Files         117      449     +332     
  Lines       12336    22599   +10263     
  Branches        0     2367    +2367     
==========================================
+ Hits         8817    15036    +6219     
- Misses       3519     7425    +3906     
- Partials        0      138     +138
Impacted Files Coverage Δ
superset/examples/world_bank.py 100% <100%> (ø) ⬆️
...sets/src/explore/components/ExploreChartHeader.jsx 50% <0%> (ø)
superset/assets/src/components/Checkbox.jsx 100% <0%> (ø)
...perset/assets/src/dashboard/util/getEmptyLayout.js 0% <0%> (ø)
...ts/src/dashboard/util/getComponentWidthFromDrop.js 95.23% <0%> (ø)
.../assets/src/dashboard/reducers/dashboardFilters.js 88.23% <0%> (ø)
...rc/explore/components/controls/AnnotationLayer.jsx 2.46% <0%> (ø)
superset/assets/src/welcome/DashboardTable.jsx 87.5% <0%> (ø)
...erset/assets/src/dashboard/util/injectCustomCss.js 91.66% <0%> (ø)
...explore/components/controls/ColorPickerControl.jsx 85% <0%> (ø)
... and 323 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cba1bd...e00d355. Read the comment docs.

@mistercrunch mistercrunch merged commit a8f1589 into apache:master Oct 31, 2019
graceguo-supercat pushed a commit that referenced this pull request Nov 13, 2019
@dpgaspar dpgaspar added the v0.35 label Nov 15, 2019
dpgaspar pushed a commit that referenced this pull request Nov 15, 2019
@mistercrunch mistercrunch added 🍒 0.35.1 🍒 0.35.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.35 🍒 0.35.1 🍒 0.35.2 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants