Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide documentation for using a Service Account to connect to BigQuery #8462

Conversation

willbarrett
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Documents the new connection configuration method added in #8448 for BigQuery.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@dpgaspar @robdiciuccio @mistercrunch

@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

Merging #8462 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8462      +/-   ##
==========================================
- Coverage   66.58%   66.56%   -0.03%     
==========================================
  Files         449      449              
  Lines       22525    22567      +42     
  Branches     2364     2367       +3     
==========================================
+ Hits        14999    15021      +22     
- Misses       7388     7408      +20     
  Partials      138      138
Impacted Files Coverage Δ
superset/views/utils.py 76.41% <0%> (-13.36%) ⬇️
superset/connectors/sqla/models.py 84.87% <0%> (-0.09%) ⬇️
superset/views/core.py 72.15% <0%> (-0.07%) ⬇️
...rset/assets/src/messageToasts/components/Toast.jsx 93.75% <0%> (ø) ⬆️
superset/viz.py 71.29% <0%> (ø) ⬆️
superset/utils/core.py 88.65% <0%> (+0.09%) ⬆️
superset/config.py 89.34% <0%> (+0.16%) ⬆️
superset/assets/src/explore/controls.jsx 42.18% <0%> (+0.91%) ⬆️
.../explore/components/controls/DateFilterControl.jsx 40% <0%> (+2.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a757b43...dc8e70e. Read the comment docs.

@mistercrunch mistercrunch merged commit 1adf742 into apache:master Oct 29, 2019
@mistercrunch mistercrunch deleted the wbarrett/document-bigquery-connection-method branch October 29, 2019 19:31
graceguo-supercat pushed a commit that referenced this pull request Nov 13, 2019
…ery (#8462)

* Provide documentation for using a Service Account to connect to BigQuery

* Alter line wrapping for shorter lines

* Whitespace commit to trigger another build (flake)

* Another meaningless whitespace change to trigger another build
@ofirshtrull
Copy link

im in the same boat, why not add a service account?
i am about to create one now and that add PR ;-)

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants