Split up tests/db_engine_test.py #8449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbarrett
changed the title
mistercrunch
approved these changes
Oct 25, 2019
graceguo-supercat
pushed a commit
that referenced
this pull request
Nov 13, 2019
* Split up db_engine_specs_test.py into a number of targeted files * Remove db_engine_specs_test.py * isort
villebro
pushed a commit
that referenced
this pull request
Jan 4, 2020
* Split up db_engine_specs_test.py into a number of targeted files * Remove db_engine_specs_test.py * isort
mistercrunch
added
🍒 0.35.2
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* Split up db_engine_specs_test.py into a number of targeted files * Remove db_engine_specs_test.py * isort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
The db_engine_spec_test.py file was over 800 lines and targeted a number of different databases. It was difficult to find what was targeting which bit of implementation. This PR breaks up that test file into one test file per platform, as well as a base test module to inherit from for shared functionality. This should make it easier to increase test coverage of db_engine_specs going forward.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Run tests. Test files were refactored.
ADDITIONAL INFORMATION
REVIEWERS
@betodealmeida @mistercrunch @dpgaspar