Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[setup] Fix, download_url #8439

Merged
merged 2 commits into from
Oct 25, 2019
Merged

[setup] Fix, download_url #8439

merged 2 commits into from
Oct 25, 2019

Conversation

dpgaspar
Copy link
Member

CATEGORY

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Apache download URL may have changed, noticed that the download_url returns 404
(https://dist.apache.org/repos/dist/release/superset/0.34.1)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@codecov-io
Copy link

codecov-io commented Oct 24, 2019 •
edited
Loading

Codecov Report

Merging #8439 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8439   +/-   ##
=======================================
  Coverage   67.61%   67.61%           
=======================================
  Files         448      448           
  Lines       22486    22486           
  Branches     2364     2364           
=======================================
  Hits        15204    15204           
  Misses       7144     7144           
  Partials      138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786d770...6bf9e90. Read the comment docs.

villebro
villebro approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. I wonder if this was announced somewhere? Just so we can avoid similar issues in the future..

@dpgaspar
Copy link
Member Author

I'll search/ask at Apache

@dpgaspar dpgaspar merged commit 59889a4 into apache:master Oct 25, 2019
@dpgaspar dpgaspar deleted the fix/setup-download-url branch October 25, 2019 07:59
graceguo-supercat pushed a commit that referenced this pull request Nov 13, 2019
@dpgaspar
[setup] Fix, download_url (#8439)
966e9e1 
* [setup] Fix, download_url
@dpgaspar dpgaspar added the v0.35 label Dec 20, 2019
villebro pushed a commit that referenced this pull request Jan 4, 2020
@dpgaspar @villebro
[setup] Fix, download_url (#8439)
3e6a206 
* [setup] Fix, download_url
@mistercrunch mistercrunch added 🍒 0.35.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@dpgaspar @villebro
[setup] Fix, download_url (apache#8439)
6af3791 
* [setup] Fix, download_url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@mistercrunch mistercrunch Awaiting requested review from mistercrunch

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.35 🍒 0.35.2 🚢 0.36.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dpgaspar @codecov-io @villebro @mistercrunch