Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cypress] Skip another flaky sqllab test #8374

Merged
merged 1 commit into from
Oct 11, 2019
Merged

[Cypress] Skip another flaky sqllab test #8374

merged 1 commit into from
Oct 11, 2019

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Oct 11, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This is flaky too, we really need to fix these tests. But for now, skipping is better than low signal...

TEST PLAN

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@graceguo-supercat @mistercrunch @john-bodley @villebro

@etr2460 etr2460 merged commit 558680d into master Oct 11, 2019
@etr2460 etr2460 deleted the erik-ritter--skip-flaky-test branch October 11, 2019 20:02
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley approved these changes

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.35.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@etr2460 @john-bodley @graceguo-supercat @mistercrunch