-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Fix, removing deprecated function for future Python release compatibility. #8353
[tests] Fix, removing deprecated function for future Python release compatibility. #8353
Conversation
Extra info on this: https://docs.python.org/3/library/unittest.html#deprecated-aliases @MarcusSorealheis while your at it, can I ask you to change |
Codecov Report
@@ Coverage Diff @@
## master #8353 +/- ##
=======================================
Coverage 67.57% 67.57%
=======================================
Files 448 448
Lines 22529 22529
Branches 2363 2363
=======================================
Hits 15223 15223
Misses 7168 7168
Partials 138 138 Continue to review full report at Codecov.
|
thanks @dpgaspar |
@dpgaspar does this LGTM? |
here is where CI failed (which is unrelated to the change):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CATEGORY
Choose one
SUMMARY
Here, I replaced all the occurrences of
assertEquals
withassertEqual
in the test files in anticipation of its removal in future Python releases. The alias has been deprecated for sometime.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
run tests.
ADDITIONAL INFORMATION
REVIEWERS
@betodealmeida or someone else that works on tests.