Remove unused methods from Presto #8350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbarrett
approved these changes
Oct 4, 2019
| @@ -157,7 +157,7 @@ def get_view_names( | |||
|
|
|||
| if schema: | |||
| sql = ( | |||
| "SELECT table_name FROM information_schema.views" | |||
| "SELECT table_name FROM information_schema.views " | |||
Codecov Report
@@ Coverage Diff @@
## master #8350 +/- ##
==========================================
+ Coverage 67.53% 67.58% +0.05%
==========================================
Files 447 447
Lines 22644 22510 -134
Branches 2363 2363
==========================================
- Hits 15292 15214 -78
+ Misses 7214 7158 -56
Partials 138 138
Continue to review full report at Codecov.
|
serenajiang
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Oct 9, 2019
* Remove unused methods from Presto * Remove tests * Fix bug in PRESTO_SPLIT_VIEWS_FROM_TABLES * Fix lint
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
#8233 greatly simplified the logic of Presto's
expand_datamethod, leaving behind a bunch of unused methods. This PR removes them.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Tested using Presto, everything works.
ADDITIONAL INFORMATION
REVIEWERS
@willbarrett @mistercrunch