Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint in superset/db_engine_spec #8338

Merged
merged 11 commits into from
Oct 4, 2019
Merged

Fix lint in superset/db_engine_spec #8338

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
54012bf
Enable lint checking for files in db_engine_spec that have few to no
Oct 2, 2019
61122cf
Enable lint and fix issue in db_engine_spec/mysql.py
Oct 2, 2019
6d69c81
Enable pylint and fix lint for db_engine_spec/pinot.py
Oct 2, 2019
3983175
Enable lint and fix issues for db_engine_specs/hive.py
Oct 2, 2019
ea4fe10
Enable lint and fix for db_engine_spec/presto.py
Oct 2, 2019
c70fda4
Re-enable lint on base.py, fix/disable specific failures, including one
Oct 2, 2019
c6b007e
Make flake8 happy after a number of pylint fixes
Oct 2, 2019
4fa870f
Update db_engine_spec_test test cases related to Presto to support
Oct 2, 2019
2120665
automated reformatting
Oct 2, 2019
84a4e5c
One more pylint disable for druid.py
Oct 2, 2019
79f4965
Find the magic invocation that makes all the lint tools happy
Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
One more pylint disable for druid.py
  • Loading branch information
Will Barrett committed Oct 3, 2019
commit 84a4e5c90376d0a4c69bf382b27b03cb1cbf1038
2 changes: 1 addition & 1 deletion superset/db_engine_specs/druid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from superset.db_engine_specs.base import BaseEngineSpec


class DruidEngineSpec(BaseEngineSpec):
class DruidEngineSpec(BaseEngineSpec): # pylint: disable=abstract-method
"""Engine spec for Druid.io"""

engine = "druid"
Expand Down