Adding explicit Flask session cookie options to default config #8317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8317 +/- ##
==========================================
+ Coverage 67.74% 67.75% +<.01%
==========================================
Files 451 451
Lines 22699 22702 +3
Branches 2370 2370
==========================================
+ Hits 15378 15381 +3
Misses 7184 7184
Partials 137 137
Continue to review full report at Codecov.
|
dpgaspar
approved these changes
Sep 27, 2019
mistercrunch
approved these changes
Sep 28, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This will enforce a SameSite policy of
Laxfor session cookies served up by Superset.(https://www.owasp.org/index.php/SameSite)
The SameSite cookie attribute attempts to solve many of the issues associated with cross origin attacks as they relate to cookies with a single option.
In this PR, I'm basically surfacing the underlying Flask options which control these options and am providing a sensible set of defaults.
REVIEWERS
@mistercrunch @dpgaspar