[SQL Lab] Improve autocomplete #8305
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8305 +/- ##
==========================================
- Coverage 73.53% 67.75% -5.79%
==========================================
Files 115 451 +336
Lines 12396 22702 +10306
Branches 0 2370 +2370
==========================================
+ Hits 9116 15381 +6265
- Misses 3280 7184 +3904
- Partials 0 137 +137
Continue to review full report at Codecov.
|
| @@ -27,6 +27,11 @@ import { areArraysShallowEqual } from '../../reduxUtils'; | |||
|
|
|||
| const langTools = ace.acequire('ace/ext/language_tools'); | |||
|
|
|||
| const SQL_KEYWORD_AUTOCOMPLETE_SCORE = 100; | |||
There was a problem hiding this comment.
where are those score: XXXXX_ SCORE used?
There was a problem hiding this comment.
They're used by ace editor's autocomplete logic to determine the ordering of autocomplete results
| const SQL_KEYWORD_AUTOCOMPLETE_SCORE = 100; | ||
| const SCHEMA_AUTOCOMPLETE_SCORE = 60; | ||
| const TABLE_AUTOCOMPLETE_SCORE = 55; | ||
| const COLUMN_AUTOCOMPLETE_SCORE = 50; |
There was a problem hiding this comment.
When writing a query, one is probably spending more time autocompleting column names than table/schema names. Wondering if having a higher score for column names wrt schema/table names could result in a better user experience, too?
There was a problem hiding this comment.
Hmm, I'm not sure about this. I'm going to merge this refactor in, reach out to some sql lab powerusers, and come back with the results. I anticipate making some more changes here as we have other feedback about autocomplete to fix.
There was a problem hiding this comment.
Absolutely; this was not meant as a blocking comment. Btw, I briefly checked DataGrip, and it seems it gives a higher score/priority for columns than tables, so I might be on to something here after all 😄
mistercrunch
added
🏷️ bot
CATEGORY
Choose one
SUMMARY
when a user would type
selinto the autocomplete, we'd prioritize schemas containingselas opposed to the SQL keywordSELECT. This fixes that bug, and also refactors some of the code to prevent a similar issue and be clearer (read more immutable).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Type
selinto the editor, and seeSELECTas the autocomplete optionADDITIONAL INFORMATION
REVIEWERS
@graceguo-supercat @michellethomas @betodealmeida