#8294: Set moment library language during app setup

[oskarhinc]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

Make use of moment.locale method to change its language globally (as described in https://momentjs.com/docs/#/i18n/changing-locale/), when the app is set up (which is happening also on language change).

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API
• Fixes: Make use of moment library localization support #8294

[oskarhinc]

@kristw I've corrected mentioned issues.
Regarding Travis checks - are they always reliable? I'm wondering as in the previous build failed in another place than the latest one (due to request timeout as well), but it doesn't seem to be related with my changes in code.

[villebro]

@oskarhinc some tests aren't always reliable; I restarted CI, check back in a while to see if it fixes the problem.

[oskarhinc]

@villebro Thanks a lot!

[kristw]

Does it produce the same result if you call moment.locale() here without using localStorage at all?

[oskarhinc]

You're right - I've removed the usage of localStorage now

[codecov-io]

Codecov Report

Merging #8296 into master will decrease coverage by 5.79%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #8296      +/-   ##
==========================================
- Coverage   73.53%   67.74%    -5.8%     
==========================================
  Files         115      451     +336     
  Lines       12396    22700   +10304     
  Branches        0     2370    +2370     
==========================================
+ Hits         9116    15378    +6262     
- Misses       3280     7185    +3905     
- Partials        0      137     +137

Impacted Files	Coverage Δ
superset/assets/src/preamble.js	0% <0%> (ø)
...sets/src/explore/components/ExploreChartHeader.jsx	50% <0%> (ø)
superset/assets/src/components/Checkbox.jsx	100% <0%> (ø)
...perset/assets/src/dashboard/util/getEmptyLayout.js	0% <0%> (ø)
...ts/src/dashboard/util/getComponentWidthFromDrop.js	95.23% <0%> (ø)
.../assets/src/dashboard/reducers/dashboardFilters.js	88.23% <0%> (ø)
...rc/explore/components/controls/AnnotationLayer.jsx	2.46% <0%> (ø)
superset/assets/src/welcome/DashboardTable.jsx	87.5% <0%> (ø)
...erset/assets/src/dashboard/util/injectCustomCss.js	91.66% <0%> (ø)
...explore/components/controls/ColorPickerControl.jsx	85% <0%> (ø)
... and 327 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8f3eb...afe2c4b. Read the comment docs.