chore: skip flaky SQL Lab test #8282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tried 2-3 difference approaches to fix the flaky SQL Lab test that has been biting us for a while. My guess is that the flakiness comes from brace (the editor). Hoping a future release of brace and/or cypress may help with this. But for now, no test is better than a flaky one.
Codecov Report
@@ Coverage Diff @@
## master #8282 +/- ##
=======================================
Coverage 67.74% 67.74%
=======================================
Files 451 451
Lines 22696 22696
Branches 2370 2370
=======================================
Hits 15375 15375
Misses 7184 7184
Partials 137 137Continue to review full report at Codecov.
|
etr2460
approved these changes
Sep 23, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Tried 2-3 difference approaches to fix the flaky SQL Lab test that has
been biting us for a while. My guess is that the flakiness comes from
brace (the editor). Hoping a future release of brace and/or cypress
may help with this.
But for now, no test is better than a flaky one.