Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use deck.gl plugins from npm package #8258

Merged
merged 2 commits into from
Sep 19, 2019

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Sep 19, 2019

CATEGORY

Choose one

  • Refactor

SUMMARY

  • deck.gl plugins are migrated to new repo superset-ui-plugins-deckgl and published as npm package @superset-ui/legacy-preset-deckgl.

Note: These deck.gl plugins were not added to superset-ui-plugins as the CI of that repo is hitting perf limit already and they seem different from the other enough.
Note 2: The new repo could be a home for kepler plugin as well.

  • In the new repo, I have migrated the code, fix all dependencies, make them independent, lint all the code as much as I could, and add storybook for every single one of them.

See Storybook: https://apache-superset.github.io/superset-ui-plugins-deckgl

  • Old code under the visualizations folder are therefore deleted from this repo as well as dependencies that are no longer needed are removed from package.json.

TEST PLAN

Ran locally and verify that all deck.gl charts in the example look the same

REVIEWERS

@khtruong @mistercrunch @betodealmeida @etr2460

@codecov-io
Copy link

codecov-io commented Sep 19, 2019

Codecov Report

Merging #8258 into master will increase coverage by 1.88%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8258      +/-   ##
==========================================
+ Coverage   65.66%   67.55%   +1.88%     
==========================================
  Files         481      451      -30     
  Lines       23346    22551     -795     
  Branches     2572     2369     -203     
==========================================
- Hits        15331    15234      -97     
+ Misses       7877     7180     -697     
+ Partials      138      137       -1
Impacted Files Coverage Δ
...et/assets/src/visualizations/presets/MainPreset.js 0% <ø> (ø) ⬆️
superset/db_engine_specs/sqlite.py 54.83% <0%> (-16.13%) ⬇️
superset/dataframe.py 93.7% <0%> (-0.79%) ⬇️
superset/utils/core.py 88.16% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df74c6...fd0681a. Read the comment docs.

@kristw kristw merged commit 731c19b into apache:master Sep 19, 2019
@kristw kristw deleted the kristw--deck branch September 19, 2019 23:55
@kristw kristw mentioned this pull request Sep 26, 2019
1 task
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants