[init] Setting up cache before registering blueprints #7992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
approved these changes
Aug 6, 2019
12 tasks
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Aug 7, 2019
* [init] Setting up cache before registering blueprints * Update __init__.py (cherry picked from commit c6867d2)
john-bodley
added a commit
that referenced
this pull request
Aug 7, 2019
This reverts commit c6867d2.
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Aug 14, 2019
john-bodley
added a commit
that referenced
this pull request
Oct 6, 2019
serenajiang
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Oct 9, 2019
…#7992)" (apache#8005) This reverts commit c6867d2.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Having all the registration logic in
superset/__init__.pyresults in some complex cyclical logic (not I really like the model that the cookiecutter-flask package uses where the cache etc. are registered as extensions and available prior to the instantiation of the app) though this may be a limitation of using Flask-AppBuilder.It't not apparent what order we should register certain logic but we've run into an issue using Blueprints where we wanted to reference the cache which need to be defined prior to the registration of the blueprints.
TEST PLAN
CI.
ADDITIONAL INFORMATION
REVIEWERS
to: @etr2460 @graceguo-supercat @michellethomas @mistercrunch