Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve padding in NVD3Vis #6626

Merged
merged 2 commits into from
Jan 9, 2019
Merged

Improve padding in NVD3Vis #6626

merged 2 commits into from
Jan 9, 2019

Conversation

betodealmeida
Copy link
Member

I made some cosmetic adjustments to the padding in the NVD3Vis.js file for when the x labels are at 45 degrees. First, I shifted the labels to the left so they look better. Before:

screen shot 2019-01-09 at 10 59 32 am

After:

screen shot 2019-01-09 at 10 58 11 am

Now they are aligned with the middle of the first character of the label. This makes a difference in long labels. Before:

screen shot 2019-01-09 at 11 03 48 am

After:

screen shot 2019-01-09 at 11 03 34 am

I also improved the way the extra padding is computed. Before, it the maximum label had a length of X we would add X pixels to both the right and the bottom margin, resulting in excessive padding. I updated the padding to be a function of the rotation angle (for 45 degrees we use X*sqrt(2)/2 instead, eg).

@mistercrunch
Copy link
Member

LGTM

@betodealmeida betodealmeida merged commit f6ac0da into apache:master Jan 9, 2019
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Jan 11, 2019
@betodealmeida
Improve padding in NVD3Vis (apache#6626)
1454b02 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Jan 12, 2019
@betodealmeida
Improve padding in NVD3Vis (apache#6626)
662bd38 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Jan 14, 2019
@betodealmeida
Improve padding in NVD3Vis (apache#6626)
fa06f3a 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Jan 14, 2019
@betodealmeida
Improve padding in NVD3Vis (apache#6626)
b7ea411 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Jan 14, 2019
@betodealmeida @youngyjd
Improve padding in NVD3Vis (apache#6626)
c1534d5 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Jan 14, 2019
@betodealmeida
Improve padding in NVD3Vis (apache#6626)
9ce135d 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Jan 17, 2019
@betodealmeida
Improve padding in NVD3Vis (apache#6626)
b1644c4 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Jan 24, 2019
@betodealmeida
Improve padding in NVD3Vis (apache#6626)
34e1963 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
xtinec pushed a commit to lyft/incubator-superset that referenced this pull request Jan 29, 2019
@betodealmeida @xtinec
Improve padding in NVD3Vis (apache#6626)
645e638 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Jan 30, 2019
@betodealmeida
Improve padding in NVD3Vis (apache#6626)
3c6ec4e 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Jan 30, 2019
@betodealmeida
Improve padding in NVD3Vis (apache#6626)
293dd66 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Jan 30, 2019
@betodealmeida
Improve padding in NVD3Vis (apache#6626)
b053dd0 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Jan 30, 2019
@betodealmeida
Improve padding in NVD3Vis (apache#6626)
9605d4b 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Jan 30, 2019
@betodealmeida
Improve padding in NVD3Vis (apache#6626)
d6de1cb 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Jan 30, 2019
@betodealmeida
Improve padding in NVD3Vis (apache#6626)
5fec51d 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Jan 30, 2019
@betodealmeida
Improve padding in NVD3Vis (apache#6626)
4266b8c 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
(cherry picked from commit 645e638)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Jan 30, 2019
@betodealmeida
Improve padding in NVD3Vis (apache#6626)
0169876 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
(cherry picked from commit 645e638)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Jan 31, 2019
@betodealmeida
Improve padding in NVD3Vis (apache#6626)
4271f99 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
(cherry picked from commit 645e638)
xtinec pushed a commit to lyft/incubator-superset that referenced this pull request Feb 2, 2019
@betodealmeida @xtinec
Improve padding in NVD3Vis (apache#6626)
c7f0931 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
(cherry picked from commit 645e638)
xtinec pushed a commit to lyft/incubator-superset that referenced this pull request Feb 4, 2019
@betodealmeida @xtinec
Improve padding in NVD3Vis (apache#6626)
1efd8ca 
* WIP, fixing padding

* Remove testing code

(cherry picked from commit f6ac0da)
(cherry picked from commit 645e638)
@kristw kristw mentioned this pull request Feb 7, 2019
Merged
@kristw kristw added enhancement:request Enhancement request submitted by anyone from the community and removed #refine labels Mar 20, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels enhancement:request Enhancement request submitted by anyone from the community 🚢 0.34.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@betodealmeida @mistercrunch @kristw