Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning a version of click to fix travis #5975

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

michellethomas
Copy link
Contributor

@michellethomas michellethomas commented Sep 26, 2018

Click recently came out with a new version where "Subcommands that are named by the function now automatically have the underscore replaced with a dash. If you register a function named my_command it becomes my-command in the command line interface." This breaks tests as it affects some cli commands superset load_examples is now superset load-examples.

Pinning to the previous version of click before this change to fix travis.
@williaster @john-bodley @kristw

@codecov-io
Copy link

codecov-io commented Sep 26, 2018

Codecov Report

Merging #5975 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5975      +/-   ##
==========================================
+ Coverage   63.52%   63.56%   +0.04%     
==========================================
  Files         393      393              
  Lines       23667    23667              
  Branches     2638     2638              
==========================================
+ Hits        15034    15044      +10     
+ Misses       8620     8610      -10     
  Partials       13       13
Impacted Files Coverage Δ
superset/connectors/sqla/models.py 81.13% <0%> (+0.75%) ⬆️
superset/db_engine_specs.py 55.7% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 569f221...b80ad44. Read the comment docs.

Copy link
Contributor

@kristw kristw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit 52033cb into apache:master Sep 26, 2018
@mistercrunch
Copy link
Member

Sounds like that means that installing using pip install superset won't work. We should fix setup.py as well.

arpit-agarwal pushed a commit to ThalesGroup/incubator-superset that referenced this pull request Oct 1, 2018
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants