Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removing legend #5932

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Allow removing legend #5932

merged 1 commit into from
Sep 19, 2018

Conversation

betodealmeida
Copy link
Member

The deck.gl scatter and screengrid visualizations have a custom legend for group bys. I added an option to hide the legend.

@codecov-io
Copy link

Codecov Report

Merging #5932 into master will increase coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5932      +/-   ##
==========================================
+ Coverage   48.16%   48.22%   +0.05%     
==========================================
  Files         393      393              
  Lines       23596    23596              
  Branches     2630     2630              
==========================================
+ Hits        11366    11379      +13     
+ Misses      12230    12217      -13
Impacted Files Coverage Δ
superset/assets/src/explore/controls.jsx 27.73% <ø> (ø) ⬆️
superset/assets/src/visualizations/Legend.jsx 0% <0%> (ø) ⬆️
superset/views/core.py 74.22% <0%> (+0.22%) ⬆️
superset/models/core.py 85.09% <0%> (+0.33%) ⬆️
superset/db_engine_specs.py 55.45% <0%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 549328f...9304a70. Read the comment docs.

@mistercrunch
Copy link
Member

LGTM

@betodealmeida betodealmeida merged commit 71f014e into apache:master Sep 19, 2018
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit 71f014e)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
(cherry picked from commit 71f014e)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
(cherry picked from commit 71f014e)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
(cherry picked from commit 71f014e)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
(cherry picked from commit 71f014e)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
(cherry picked from commit 71f014e)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
(cherry picked from commit 71f014e)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
(cherry picked from commit 71f014e)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Oct 29, 2018
(cherry picked from commit 71f014e)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
(cherry picked from commit 71f014e)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
(cherry picked from commit 71f014e)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
(cherry picked from commit 71f014e)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
(cherry picked from commit 71f014e)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
(cherry picked from commit 71f014e)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
(cherry picked from commit 71f014e)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
(cherry picked from commit 71f014e)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants