Fix CSS theme flickering on FAB pages #5880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the recent PRs around webpack 4 and reloading, FAB pages have been flickering on load, where a themeless Superset is shown for a fraction of a second until the bootstrap theme gets loaded up. This addresses it by moving the theme JS to the head section of the html page.
williaster
approved these changes
Sep 12, 2018
|
Since you are at this. There is another issue about the entry point. Right now there are duplicate For example in the <script src="/static/assets/dist/vendors-addSlice-common-dashboard-explore-profile-sqllab-theme-welcome.0fe210d7.chunk.js"></script>
<script src="/static/assets/dist/vendors-dashboard-explore-profile-sqllab-theme-welcome.0fe210d7.chunk.js"></script>
<script src="/static/assets/dist/theme.0fe210d7.entry.js"></script>
<script src="/static/assets/dist/vendors-addSlice-common-dashboard-explore-profile-sqllab-theme-welcome.0fe210d7.chunk.js"></script>
<script src="/static/assets/dist/vendors-addSlice-common-dashboard-explore-profile-sqllab-welcome.0fe210d7.chunk.js"></script>
<script src="/static/assets/dist/addSlice-common-dashboard-explore-profile-sqllab-welcome.0fe210d7.chunk.js"></script>
<script src="/static/assets/dist/common.0fe210d7.entry.js"></script>Because each entry in the js manifest lists an array of chunks each entry point needs, independent of other entry points. When we render this directly to FAB template, it does not de-dup. XHR Performance-wise not too bad as browser only fetches and parses once, but for correctness, if the chunk executes something, it executes multiple time. I can open a separate issue if you think this is too big. |
|
I'll just land this for now as my goal was just to get rid of the flickering. |
kristw
pushed a commit
to kristw/incubator-superset
that referenced
this pull request
Sep 18, 2018
Since the recent PRs around webpack 4 and reloading, FAB pages have been flickering on load, where a themeless Superset is shown for a fraction of a second until the bootstrap theme gets loaded up. This addresses it by moving the theme JS to the head section of the html page. (cherry picked from commit 80faa8d)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
Since the recent PRs around webpack 4 and reloading, FAB pages have been flickering on load, where a themeless Superset is shown for a fraction of a second until the bootstrap theme gets loaded up. This addresses it by moving the theme JS to the head section of the html page.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
Since the recent PRs around webpack 4 and reloading, FAB pages have been flickering on load, where a themeless Superset is shown for a fraction of a second until the bootstrap theme gets loaded up. This addresses it by moving the theme JS to the head section of the html page.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the recent PRs around webpack 4 and reloading, FAB pages have been
flickering on load, where a themeless Superset is shown for a fraction
of a second until the bootstrap theme gets loaded up.
This addresses it by moving the theme JS to the head section of the html
page.
related to #5813
@williaster @kristw @betodealmeida