Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Teradata #5870

Merged
merged 2 commits into from
Sep 13, 2018
Merged

Enable Teradata #5870

merged 2 commits into from
Sep 13, 2018

Conversation

livinm
Copy link
Contributor

@livinm livinm commented Sep 12, 2018

New DB engine spec for Teradata:

  • LimitMethod should be WRAP_SQL since Teradata does not supporting "LIMIT" clause (TOP) - without this change sqllab does not work
  • Timegrains for Teradata are added

New DB engine spec for Teradata:
- LimitMethod should be WRAP_SQL since Teradata does not supporting "LIMIT" clause  (TOP)
- Timegrains for Teradata is added
@codecov-io
Copy link

codecov-io commented Sep 12, 2018

Codecov Report

Merging #5870 into master will decrease coverage by 14.25%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5870       +/-   ##
===========================================
- Coverage      78%   63.74%   -14.26%     
===========================================
  Files          46      374      +328     
  Lines        9314    23331    +14017     
  Branches        0     2607     +2607     
===========================================
+ Hits         7265    14873     +7608     
- Misses       2049     8445     +6396     
- Partials        0       13       +13
Impacted Files Coverage Δ
superset/db_engine_specs.py 55.45% <100%> (+0.26%) ⬆️
...sets/src/explore/components/ExploreChartHeader.jsx 71.42% <0%> (ø)
superset/assets/src/components/Checkbox.jsx 100% <0%> (ø)
...perset/assets/src/dashboard/util/getEmptyLayout.js 0% <0%> (ø)
...ts/src/dashboard/util/getComponentWidthFromDrop.js 96.15% <0%> (ø)
...erset/assets/src/SqlLab/components/QuerySearch.jsx 69.36% <0%> (ø)
...rc/explore/components/controls/AnnotationLayer.jsx 22.92% <0%> (ø)
superset/assets/src/welcome/DashboardTable.jsx 81.81% <0%> (ø)
...erset/assets/src/dashboard/util/injectCustomCss.js 91.66% <0%> (ø)
...ets/src/dashboard/components/dnd/DragDroppable.jsx 97.91% <0%> (ø)
... and 319 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 657993d...5db551f. Read the comment docs.

@mistercrunch
Copy link
Member

@livinm
Copy link
Contributor Author

livinm commented Sep 13, 2018

@mistercrunch added
see #5885

@mistercrunch mistercrunch merged commit 83fa7af into apache:master Sep 13, 2018
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* Enable Teradata 

New DB engine spec for Teradata:
- LimitMethod should be WRAP_SQL since Teradata does not supporting "LIMIT" clause  (TOP)
- Timegrains for Teradata is added

* Update formatting to pass flake8 tests
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants