[SIP-4] replace explorer ajax calls with SupersetClient
#5869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2018
williaster
commented
Sep 12, 2018
| export default function setupSupersetClient() { | ||
| // The following are needed to mock out SupersetClient requests | ||
| // including CSRF authentication and initialization | ||
| // global.FormData = window.FormData; |
There was a problem hiding this comment.
going to remove this file and add it as a cherry-pick to share across these ajax refactors. this line is also needed.
williaster
force-pushed
the
chris--ajax-explorer
branch
from
e22e5f5 to
f334912
Compare
kristw
approved these changes
Sep 12, 2018
| @@ -1,7 +1,9 @@ | |||
| /* global AbortController */ | |||
There was a problem hiding this comment.
can this be added at project level?
williaster
force-pushed
the
chris--ajax-explorer
branch
from
3e17d65 to
d9cc68b
Compare
williaster
force-pushed
the
chris--ajax-explorer
branch
2 times, most recently
from
88ca537 to
3afe2dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #5869 +/- ##
=======================================
Coverage 77.23% 77.23%
=======================================
Files 47 47
Lines 9349 9349
=======================================
Hits 7221 7221
Misses 2128 2128Continue to review full report at Codecov.
|
kristw
approved these changes
Oct 16, 2018
williaster
force-pushed
the
chris--ajax-explorer
branch
from
c799144 to
8fe201d
Compare
This was referenced Oct 17, 2018
This was referenced Oct 18, 2018
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* [superset-client] initialize SupersetClient in app setup * [core] replace explore ajax calls with SupersetClient * [core] fix SupersetClient explore tests * [core] remove _packages mistake directory * remove unused files * add yarn.lock * always render modal * [superset-client][jest] fix SaveModal_spec * [lint] remove unnecessary AbortController global * yarn.lock
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one of a few that implements the final step 4) discussed in #5772 and refactors just explorer-specific ajax calls (not including charts) for easier review.
Note that the new
@superset-ui/coredep + setup forSupersetClientis duplicated across all ajax PRsSupersetClient#5854SupersetClient#5875SupersetClient#5896@kristw @mistercrunch @graceguo-supercat @michellethomas @conglei