Code

[SIP-5] Refactor nvd3#5838

Code

Merged

williaster merged 44 commits intoapache:masterapache/superset:masterfrom kristw:kristw-nvd3kristw/incubator-superset:kristw-nvd3Copy head branch name to clipboardSep 17, 2018

+797-434

Commits

Commits on Sep 13, 2018

• move into folder and scaffold adaptor

  kristw

  committed
  15a337d

  Copy full SHA for 15a337d

• extract width and height

  kristw

  committed
  b52adec

  Copy full SHA for b52adec

• remove jquery

  kristw

  committed
  c62b075

  Copy full SHA for c62b075

• extract showBrush

  kristw

  committed
  697391a

  Copy full SHA for 697391a

• extract lineInterpolation

  kristw

  committed
  ac2c4a7

  Copy full SHA for ac2c4a7

• extract xAxisFormat and yAxisFormat

  kristw

  committed
  d187306

  Copy full SHA for d187306

• extract annotationData

  kristw

  committed
  59b9c22

  Copy full SHA for 59b9c22

• extract xTicksLayout and colorScheme

  kristw

  committed
  f16deeb

  Copy full SHA for f16deeb

• extract showXXX

  kristw

  committed
  f5fafb2

  Copy full SHA for f5fafb2

• extract x and y axis labels

  kristw

  committed
  7d330b7

  Copy full SHA for 7d330b7

• extract showminmax

  kristw

  committed
  672234b

  Copy full SHA for 672234b

• extract pie chart props

  kristw

  committed
  5bf69e6

  Copy full SHA for 5bf69e6

• extract area chart props

  kristw

  committed
  b907bee

  Copy full SHA for b907bee

• extract logscale and yAxisBounds

  kristw

  committed
  0116d00

  Copy full SHA for 0116d00

• extract margin

  kristw

  committed
  eb23184

  Copy full SHA for eb23184

• extract bubble props x,y,size

  kristw

  committed
  e0db6b7

  Copy full SHA for e0db6b7

• extract contribution, comparisonType and color_picker

  kristw

  committed
  ea3e6ef

  Copy full SHA for ea3e6ef

• remove the last fd.xxx

  kristw

  committed
  1dafe0f

  Copy full SHA for 1dafe0f

• remove unnecessary variables

  kristw

  committed
  ffdb7d4

  Copy full SHA for ffdb7d4

• remove slice.container

  kristw

  committed
  472338c

  Copy full SHA for 472338c

• fix unit test reference

  kristw

  committed
  4c21492

  Copy full SHA for 4c21492

• Rewrite logic to compute max label lengths to use only d3, not jquery.

  kristw

  committed
  e998d22

  Copy full SHA for e998d22

• extract annotationLayers and no more slice.xxx in nvd3vis

  kristw

  committed
  595f40e

  Copy full SHA for 595f40e

• rename x, y, size to xField, yField, sizeField

  kristw

  committed
  d233223

  Copy full SHA for d233223

• use arrow function

  kristw

  committed
  ae2c8bd

  Copy full SHA for ae2c8bd

• move tooltip function

  kristw

  committed
  98d5a6b

  Copy full SHA for 98d5a6b

• extract helper functions into utils

  kristw

  committed
  3416f02

  Copy full SHA for 3416f02

• remove unused argument

  kristw

  committed
  34f447b

  Copy full SHA for 34f447b

• fix height calculation and show bar labels

  kristw

  committed
  1cd2394

  Copy full SHA for 1cd2394

• rename function

  kristw

  committed
  ab4c7a0

  Copy full SHA for ab4c7a0

• update unit test

  kristw

  committed
  203f229

  Copy full SHA for 203f229

• organize tooltip generator

  kristw

  committed
  fce3ca2

  Copy full SHA for fce3ca2

• update line_multi

  kristw

  committed
  3696ccc

  Copy full SHA for 3696ccc

• Add proptypes for data

  kristw

  committed
  48540f5

  Copy full SHA for 48540f5

• list proptypes for data

  kristw

  committed
  be450fe

  Copy full SHA for be450fe

• extract tooltip function for bubble chart

  kristw

  committed
  73ebb13

  Copy full SHA for 73ebb13

• rename variables

  kristw

  committed
  b28c08e

  Copy full SHA for b28c08e

• remove console.log

  kristw

  committed
  dfab7e3

  Copy full SHA for dfab7e3

• enumerate vizTypes and pieLabelType

  kristw

  committed
  4c45f5f

  Copy full SHA for 4c45f5f

• merge master and resolved conflicts

  kristw

  committed
  a085593

  Copy full SHA for a085593

• parse maxBubble

  kristw

  committed
  ed9fb95

  Copy full SHA for ed9fb95

• use new color scale

  kristw

  committed
  22435a9

  Copy full SHA for 22435a9

• fix import"

  kristw

  committed
  cde5136

  Copy full SHA for cde5136

Commits on Sep 14, 2018

• remove line

  kristw

  committed
  58214bd

  Copy full SHA for 58214bd