[SIP-5] Remove unused function #easy-review #5825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5825 +/- ##
==========================================
+ Coverage 63.75% 63.75% +<.01%
==========================================
Files 366 366
Lines 23129 23127 -2
Branches 2597 2596 -1
==========================================
- Hits 14745 14744 -1
+ Misses 8369 8368 -1
Partials 15 15
Continue to review full report at Codecov.
|
kristw
added a commit
to kristw/incubator-superset
that referenced
this pull request
Sep 11, 2018
* remove unused function * remove comment (cherry picked from commit a9952bb)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* remove unused function * remove comment
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* remove unused function * remove comment
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verboseMetricNameis not used anywhere after the chart refactor.table.jsas I misunderstood something and found where thetableFilterfield is used.