Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirect to SQL Lab #5777

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Fix redirect to SQL Lab #5777

merged 1 commit into from
Aug 30, 2018

Conversation

betodealmeida
Copy link
Member

This PR fix a few things:

  1. The SQL Lab redirect was not working correctly, since changes to the form controls were not being picked up. Instead, the auto-populated query corresponded to the saved chart, not the one being visualized.
  2. The redirect code was using the URL interface without a polyfill. I changed the code to use uri.js, which is a dependency.
  3. The error message was using the notify code that was removed. I changed it to use the chart alerting instead.

@codecov-io
Copy link

codecov-io commented Aug 29, 2018

Codecov Report

Merging #5777 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5777      +/-   ##
==========================================
+ Coverage   63.73%   63.74%   +0.01%     
==========================================
  Files         364      364              
  Lines       23090    23092       +2     
  Branches     2568     2568              
==========================================
+ Hits        14717    14721       +4     
+ Misses       8358     8356       -2     
  Partials       15       15
Impacted Files Coverage Δ
superset/assets/src/chart/chartReducer.js 16.94% <0%> (-0.6%) ⬇️
superset/assets/src/chart/chartAction.js 50% <40%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00f2771...e8481ff. Read the comment docs.

@mistercrunch
Copy link
Member

LGTM

@betodealmeida betodealmeida merged commit 8af3e1f into apache:master Aug 30, 2018
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Oct 29, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
(cherry picked from commit 8af3e1f)
(cherry picked from commit 1d64350)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants