Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqllab] Include visual feedback that SQL Lab query is limited #5774

Closed
wants to merge 2 commits into from

Conversation

jeffreythewang
Copy link
Contributor

@jeffreythewang jeffreythewang commented Aug 29, 2018

As an extension to #5392, I think it makes sense to include visual feedback when the query has been limited on the backend.

screen shot 2018-08-29 at 4 32 55 pm

@timifasubaa @villebro

@codecov-io
Copy link

codecov-io commented Aug 29, 2018

Codecov Report

Merging #5774 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5774      +/-   ##
==========================================
+ Coverage   77.55%   77.55%   +<.01%     
==========================================
  Files          47       47              
  Lines        9485     9486       +1     
==========================================
+ Hits         7356     7357       +1     
  Misses       2129     2129
Impacted Files Coverage Δ
superset/sql_lab.py 71.92% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0f685b...a7afa95. Read the comment docs.

@villebro
Copy link
Member

@jeffreythewang #5392 needs some work as it introduced a regression (see discussion), probably best to wait for a fix for that first and then take a new look at this PR.

@jeffreythewang
Copy link
Contributor Author

@villebro @timifasubaa A bit late, but I just rebased this after seeing that the regression mentioned in #5392 was resolved.

@kristw kristw added the enhancement:request Enhancement request submitted by anyone from the community label Dec 24, 2018
@stale
Copy link

stale bot commented Apr 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 10, 2019
@stale stale bot closed this Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:request Enhancement request submitted by anyone from the community inactive Inactive for >= 30 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants