Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIP-5] Refactor calendar chart #5760

Merged
merged 5 commits into from
Sep 5, 2018
Merged

[SIP-5] Refactor calendar chart #5760

merged 5 commits into from
Sep 5, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Aug 28, 2018 •
edited
Loading

  • Extract slice and formData
  • Update some default values

pasted_image_8_28_18__12_14_pm

@kristw kristw mentioned this pull request Aug 28, 2018
Closed
@codecov-io
Copy link

codecov-io commented Aug 28, 2018 •
edited
Loading

Codecov Report

Merging #5760 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5760      +/-   ##
==========================================
- Coverage   63.34%   63.32%   -0.03%     
==========================================
  Files         364      364              
  Lines       23051    23060       +9     
  Branches     2565     2566       +1     
==========================================
  Hits        14602    14602              
- Misses       8434     8443       +9     
  Partials       15       15
Impacted Files Coverage Δ
superset/assets/src/explore/controls.jsx 46.26% <ø> (ø) ⬆️
superset/assets/src/visualizations/cal_heatmap.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ecd72...f7c081a. Read the comment docs.

williaster
williaster approved these changes Sep 5, 2018
View reviewed changes
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@williaster williaster merged commit 2811498 into apache:master Sep 5, 2018
@kristw kristw deleted the kristw-calendar branch September 5, 2018 18:52
kristw added a commit to kristw/incubator-superset that referenced this pull request Sep 5, 2018
@kristw
[SIP-5] Refactor calendar chart (apache#5760)
7bf35e4 
* remove stroke

* update style and annotate data type

* update prop type

* bring back utc code

* add comments

(cherry picked from commit 2811498)
@kristw kristw mentioned this pull request Sep 5, 2018
Merged
@conglei conglei mentioned this pull request Sep 11, 2018
Closed
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@kristw @betodealmeida
[SIP-5] Refactor calendar chart (apache#5760)
1968d2f 
* remove stroke

* update style and annotate data type

* update prop type

* bring back utc code

* add comments
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@kristw @williaster
[SIP-5] Refactor calendar chart (apache#5760)
e62f888 
* remove stroke

* update style and annotate data type

* update prop type

* bring back utc code

* add comments
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kristw @codecov-io @williaster @mistercrunch