Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-5] Refactor and repair partition #5718

Merged
merged 7 commits into from
Aug 29, 2018
Merged

[SIP-5] Refactor and repair partition #5718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
651242b
Extract slice and formData
kristw Aug 24, 2018
7e1345f
reorder functions
kristw Aug 24, 2018
e67cbf9
fix tooltip
kristw Aug 24, 2018
a1657f7
remove commented code
kristw Aug 24, 2018
f26e2ee
remove commented code and rename variables
kristw Aug 29, 2018
a2a7506
remove verboseMap
kristw Aug 29, 2018
a71c0d8
rename kx, ky to zoomX, zoomY
kristw Aug 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion superset/assets/src/visualizations/partition.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
.partition {
position: relative;
}

.partition .chart {
display: block;
margin: auto;
Expand All @@ -18,10 +22,25 @@

.partition g text {
font-weight: bold;
pointer-events: none;
fill: rgba(0, 0, 0, 0.8);
}

.partition g:hover text {
fill: rgba(0, 0, 0, 1);
}

.partition .partition-tooltip {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice at some point to have consistent colors/padding across things like chart tooltips. not sure how to best do that in the plugin world... css in javascript makes it easy to pass variables around. something to think about.

Copy link
Contributor Author

@kristw kristw Aug 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to get rid of in-chart tooltips and make all use vx tooltip. Can do another sweep after converting these to react

position: absolute;
top: 0;
left: 0;
opacity: 0;
padding: 5px;
pointer-events: none;
background-color: rgba(255,255,255, 0.75);
border-radius: 5px;
}

.partition-tooltip td {
padding-left: 5px;
font-size: 11px;
}
Loading