-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIP-5] Refactor pivot table #5705
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5705 +/- ##
==========================================
- Coverage 63.77% 63.73% -0.04%
==========================================
Files 364 364
Lines 23097 23108 +11
Branches 2572 2573 +1
==========================================
Hits 14729 14729
- Misses 8353 8364 +11
Partials 15 15
Continue to review full report at Codecov.
|
b889a3c
to
7a86b53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again for all the hard work on untangling these!
* extract slice and formData * rename variables * update proptypes and add comments (cherry picked from commit 5eff7a8)
* extract slice and formData * rename variables * update proptypes and add comments
* extract slice and formData * rename variables * update proptypes and add comments
slice
andformData
according to [SIP-5]@williaster @conglei @graceguo-supercat