[SIP-5] Refactor sankey #5701
Merged
[SIP-5] Refactor sankey #5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5701 +/- ##
==========================================
- Coverage 63.45% 63.44% -0.02%
==========================================
Files 361 361
Lines 22972 22976 +4
Branches 2557 2557
==========================================
Hits 14576 14576
- Misses 8381 8385 +4
Partials 15 15
Continue to review full report at Codecov.
|
williaster
approved these changes
Aug 28, 2018
|
|
||
| div.selectAll('*').remove(); | ||
| const svg = div.append('svg') | ||
| .attr('width', width + margin.left + margin.right) | ||
| .attr('height', height + margin.top + margin.bottom) | ||
| .attr('width', innerWidth + margin.left + margin.right) |
There was a problem hiding this comment.
could potentially just use width/height here but nbd
kristw
added a commit
to kristw/incubator-superset
that referenced
this pull request
Sep 5, 2018
* extract slice and formdata from sankey * use arrow function * reorganize imports (cherry picked from commit 506cfd1)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* extract slice and formdata from sankey * use arrow function * reorganize imports
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* extract slice and formdata from sankey * use arrow function * reorganize imports
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sliceandformDataaccording to [SIP-5]@williaster @conglei