[SIP-5] Refactor treemap #5670
Merged
[SIP-5] Refactor treemap #5670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5670 +/- ##
==========================================
- Coverage 63.43% 63.38% -0.05%
==========================================
Files 361 361
Lines 22977 22995 +18
Branches 2558 2559 +1
==========================================
Hits 14575 14575
- Misses 8387 8405 +18
Partials 15 15
Continue to review full report at Codecov.
|
williaster
approved these changes
Aug 23, 2018
| const formatNumber = d3.format(numberFormat); | ||
|
|
||
| function draw(data, eltWidth, eltHeight) { | ||
| const margin = { |
There was a problem hiding this comment.
should we pass this in as a prop? maybe in the future / not saying it should be part of this PR, just seems weird to include it, with all 0s, and not have it be set-able.
There was a problem hiding this comment.
I added prop margin.
kristw
added a commit
to kristw/incubator-superset
that referenced
this pull request
Aug 27, 2018
* refactor treemap * refactor treemap code * Add proptypes * add proptypes for tree * Add margin prop (cherry picked from commit 54ae215)
kristw
added a commit
to kristw/incubator-superset
that referenced
this pull request
Aug 27, 2018
* refactor treemap * refactor treemap code * Add proptypes * add proptypes for tree * Add margin prop (cherry picked from commit 54ae215)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
* refactor treemap * refactor treemap code * Add proptypes * add proptypes for tree * Add margin prop
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* refactor treemap * refactor treemap code * Add proptypes * add proptypes for tree * Add margin prop
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple the visualization code from
sliceandformDataTest
Ran a development instance with the code above and verified with production instance that they produce the same results.
@williaster @conglei @graceguo-supercat