allow selection of dbs where csv can be uploaded to #5393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timifasubaa
force-pushed
the
add_can_csv_upload_to_dbs
branch
2 times, most recently
from
c4bcdb6 to
bac9bdd
Compare
Codecov Report
@@ Coverage Diff @@
## master #5393 +/- ##
==========================================
+ Coverage 61.21% 61.21% +<.01%
==========================================
Files 373 373
Lines 23709 23710 +1
Branches 2750 2750
==========================================
+ Hits 14513 14514 +1
Misses 9181 9181
Partials 15 15
Continue to review full report at Codecov.
|
john-bodley
reviewed
Jul 16, 2018
superset/forms.py
Outdated
| @@ -50,7 +50,9 @@ def filter_not_empty_values(value): | |||
| class CsvToDatabaseForm(DynamicForm): | |||
| # pylint: disable=E0211 | |||
| def all_db_items(): | |||
| return db.session.query(models.Database) | |||
There was a problem hiding this comment.
It might be a good idea to rename this method as it's no longer all.
timifasubaa
force-pushed
the
add_can_csv_upload_to_dbs
branch
5 times, most recently
from
1e52d59 to
62cff2f
Compare
|
@john-bodley Done |
john-bodley
reviewed
Jul 17, 2018
|
|
||
|
|
||
| def upgrade(): | ||
| op.add_column('dbs', sa.Column('allow_csv_upload', sa.Boolean(), nullable=True)) |
There was a problem hiding this comment.
What does a NULL value imply here?
timifasubaa
force-pushed
the
add_can_csv_upload_to_dbs
branch
from
62cff2f to
e258898
Compare
timifasubaa
force-pushed
the
add_can_csv_upload_to_dbs
branch
from
e258898 to
239f752
Compare
john-bodley
approved these changes
Jul 17, 2018
timifasubaa
added a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Jul 26, 2018
(cherry picked from commit 7f8eaee)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, all databases are listed when the user tries to upload to CSV.
This PR allows the administrator select which databases people can upload CSV to. I set it to True by default so there is no breakage upon deploy.
@john-bodley @mistercrunch