-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic elastic connector implementation #5358
Conversation
Can you keep my commit(s) intact so we can identify what's been put on top easily and keep have the history attributed to the right contributor. |
@mistercrunch I have cherry picked your changes and again merged the change, Thanks for pointing it. |
f241a74
to
8b49b77
Compare
@mistercrunch Please have a look for the validity of implementation, if it looks good, let us know the further steps to fix the integration issues |
base_order = ('datasource_name', 'asc') | ||
description_columns = { | ||
'slices': _( | ||
'The list of slices associated with this table. By ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use the term "slice" anymore and use "chart" instead. We haven't remove slice
references to object names and such, but from all user-facing terminology
That's generally the right direction. I think the though part will be around filling up the methods in |
Codecov Report
@@ Coverage Diff @@
## master #5358 +/- ##
==========================================
+ Coverage 48.34% 58.95% +10.6%
==========================================
Files 328 375 +47
Lines 14762 24153 +9391
Branches 2758 2758
==========================================
+ Hits 7137 14239 +7102
- Misses 7610 9899 +2289
Partials 15 15
Continue to review full report at Codecov.
|
@mistercrunch we are getting the following error |
Hi @mistercrunch, Please let us know the correct way to merge head as , every time there is a new checkin in master we get multiple head issue |
The requirements.txt file lists |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I tried running the code for earlier PR 2953 raised for elastic search , but i was not able to run it due to some package issue,
I have updated the code and , now it is able to connect to elastic search , however ui view and agg function needs to be corrected further
upgrade steps
cd $SUPERSET_HOME
pip install . --upgrade
superset db upgrade
superset init