[Table Viz] Table columns not match with group_by control #5329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5329 +/- ##
==========================================
+ Coverage 61.34% 61.37% +0.03%
==========================================
Files 373 373
Lines 23521 23526 +5
Branches 2725 2727 +2
==========================================
+ Hits 14429 14440 +11
+ Misses 9079 9073 -6
Partials 13 13
Continue to review full report at Codecov.
|
|
Sorry when we were talking about this yesterday I didn't realize that sortBy shouldn't be a list. I think we should figure out why sortBy is a list in this situation. |
graceguo-supercat
force-pushed
the
gg-FixTableVizColumn
branch
2 times, most recently
from
20004fb to
a0f386f
Compare
superset/viz.py
Outdated
| @@ -509,7 +509,7 @@ def query_obj(self): | |||
| 'Choose either fields to [Group By] and [Metrics] or ' | |||
| '[Columns], not both')) | |||
|
|
|||
| sort_by = fd.get('timeseries_limit_metric') or [] | |||
| sort_by = fd.get('timeseries_limit_metric') or None | |||
There was a problem hiding this comment.
You can remove the or None here, if get fails sort_by will be None
graceguo-supercat
force-pushed
the
gg-FixTableVizColumn
branch
from
a0f386f to
5ded0fb
Compare
michellethomas
approved these changes
Jul 16, 2018
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Jul 19, 2018
(cherry picked from commit 0d10cc5)
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 27, 2018
(cherry picked from commit 0d10cc5)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jul 31, 2018
(cherry picked from commit 0d10cc5)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
(cherry picked from commit 0d10cc5)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 3, 2018
(cherry picked from commit 0d10cc5)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 4, 2018
(cherry picked from commit 0d10cc5)
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Aug 4, 2018
(cherry picked from commit 0d10cc5)
mistercrunch
pushed a commit
that referenced
this pull request
Aug 12, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🍒 0.27.0
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timeseries_limit_metricparameter is supposed to be single value but in the slice record I seetimeseries_limit_metric=[]. This caused table viz dropped last column.@michellethomas @GabeLoins