Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dash builder fix] combine markdown and slice name, slice picker height #5165

Merged
merged 3 commits into from
Jun 15, 2018
Merged

[dash builder fix] combine markdown and slice name, slice picker height #5165

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4428c3
combine markdown code and markdown slice name
Jun 8, 2018
0ea8bf4
allow dynamic height for slice picker cell
Jun 8, 2018
a13c90c
add word break for long datasource name
Jun 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions superset/assets/src/dashboard/stylesheets/builder-sidepane.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
}

.card-title {
margin-right: 60px;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is to wrap title.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@graceguo-supercat this is regardless of whether the slice has been added, right? I think we only want an early wrap if it has been added/the ADDED label is there?

margin-bottom: 8px;
font-weight: 800;
}
Expand All @@ -96,8 +97,12 @@
flex-direction: column;

.item {
span:first-child {
font-weight: 400;
span {
word-break: break-all;

&:first-child {
font-weight: 400;
}
}
}
}
Expand Down