Fixing time table viz for adhoc metrics #5117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time table viz is broken for adhoc metrics. In the time table viz MetricOption is passed metric information that was gathered from
slice.datasource.metrics
, but AdhocMetrics aren't in that list so it errors. We can pass through the metric if it's already an object.MetricOption
in this case is just being used to display the metric name or verbose name with a link from a given url. So it's not a problem that metrics from the database are structured differently from AdhocMetrics, the label/name/verbose name is the only necessary prop.@GabeLoins @mistercrunch @graceguo-supercat