[Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0 #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
force-pushed
the
gabe_and_john_add_fix_for_druid_version
branch
5 times, most recently
from
3227461 to
e309218
Compare
gabe-lyons
force-pushed
the
gabe_and_john_add_fix_for_druid_version
branch
from
e309218 to
be99931
Compare
Codecov Report
@@ Coverage Diff @@
## master #5030 +/- ##
==========================================
+ Coverage 77.34% 77.35% +<.01%
==========================================
Files 44 44
Lines 8671 8677 +6
==========================================
+ Hits 6707 6712 +5
- Misses 1964 1965 +1
Continue to review full report at Codecov.
|
|
LGTM |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 21, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the AdhocMetric feature, we construct Druid queries by taking a column object and an aggregate from the user and construct a druid JSON blob in the flask app. However, the query object is not always a function of just the column's type and the aggregate chosen.
Depending on the Druid version being used, we want to sum floats using
doubleSumin versionsearlier than 11.0.0 and sum floats using
floatSumin versions including and after 11.0.0A great explanation of why this is the case is provided here: https://groups.google.com/forum/#!topic/druid-development/VEYkW_5dWd8
reviewers:
@john-bodley @michellethomas @mistercrunch @betodealmeida