Rename "slice" to "chart" and update translations #5008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5008 +/- ##
==========================================
+ Coverage 77.13% 77.34% +0.21%
==========================================
Files 44 44
Lines 8649 8664 +15
==========================================
+ Hits 6671 6701 +30
+ Misses 1978 1963 -15
Continue to review full report at Codecov.
|
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Rename slice to chart and update translations * Fix unit tests
3 tasks
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
* Rename slice to chart and update translations * Fix unit tests
3 tasks
|
I think translations stopped working since this PR |
|
The whole french translation disappeared from the .po file. |
|
Should be back in master by now. |
|
@mistercrunch @betodealmeida -- superset/assets/src/i18n.jsx |
ShirmineWang
pushed a commit
to ShirmineWang/incubator-superset
that referenced
this pull request
Jul 2, 2018
Rename "slice", "slices" to "chart", "charts" in UI, but the category name, menu name remains slice so there's no need to change any permission. Refer to apache#5008 for upstream pull request.
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
* Rename slice to chart and update translations * Fix unit tests
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Rename slice to chart and update translations * Fix unit tests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames "slice" to "chart" in all user facing strings. Code has not been updated.
I also regenerated the
messages.potfile, since it hasn't been updated in a while (babel.cfgwas still pointing to the old location of Javascript files, before @mistercrunch's reorg), and updated all the.pofiles.I'll update the
pt_BRtranslation on my free time.