[Fab] cleaning up the table fab view since Metrics Control hides autogenerated metrics #4992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
force-pushed
the
gabe_hiding_columns_in_fab_view
branch
from
7669cdb to
6c6126a
Compare
Codecov Report
@@ Coverage Diff @@
## master #4992 +/- ##
======================================
Coverage 77.1% 77.1%
======================================
Files 44 44
Lines 8636 8636
======================================
Hits 6659 6659
Misses 1977 1977
Continue to review full report at Codecov.
|
gabe-lyons
changed the title
|
LGTM |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
timifasubaa
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 25, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #4914 is merged, the controls for marking columns as Count-distinct-able, Sum-able, Min-able and Max-able will no longer have any use. They are used to configure autogenerated metrics, which we hide in the metrics control.
new, more spacious fab view:
test plan: verified that the fab view no longer contains these 4 columns
dependencies:
#4914
reviewers:
@michellethomas @williaster @mistercrunch @hughhhh @john-bodley @graceguo-supercat