[deps] force flask<=1.0.0 #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flask 1.0 came out and has backwards incompatible changes. People are reporting that fresh install doesn't work anymore. fixes apache#4953 We should ship a 0.25.1 with this in
Codecov Report
@@ Coverage Diff @@
## master #4959 +/- ##
=======================================
Coverage 77.07% 77.07%
=======================================
Files 44 44
Lines 8558 8558
=======================================
Hits 6596 6596
Misses 1962 1962Continue to review full report at Codecov.
|
john-bodley
approved these changes
May 8, 2018
mistercrunch
added a commit
that referenced
this pull request
May 14, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
flask 1.0 came out and has backwards incompatible changes. People are reporting that fresh install doesn't work anymore. fixes apache#4953 We should ship a 0.25.1 with this in
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
flask 1.0 came out and has backwards incompatible changes. People are reporting that fresh install doesn't work anymore. fixes apache#4953 We should ship a 0.25.1 with this in
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
flask 1.0 came out and has backwards incompatible changes. People are reporting that fresh install doesn't work anymore. fixes apache#4953 We should ship a 0.25.1 with this in
mistercrunch
added
🍒 0.25.1
🍒 0.25.2
🍒 0.25.3
🍒 0.25.4
🍒 0.25.5
🍒 0.25.6
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
flask 1.0 came out and has backwards incompatible changes. People are reporting that fresh install doesn't work anymore. fixes apache#4953 We should ship a 0.25.1 with this in (cherry picked from commit e1590c0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flask 1.0 came out and has backwards incompatible changes. People
are reporting that fresh install doesn't work anymore.
fixes #4953
@john-bodley with most of our libs with no upper bound, any lib release backwards incompatible changes has the potential to break the pypi version. I'm not sure how to handle this. We could tell folks in our installation instruction to clone the repo and
pip install -r requirements.txtbut that seems wrong as we should make sure that a simplepip install supersetjust works. I understand that the downside of that approach is that limits users in which version of libs they may want to have the flexibility to run.We should ship a 0.25.1 with this in.