[sql lab] handle query stop race condition #4928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes apache#4926 In rare cases where the query is stopped before it is started, SQL Lab returns an unexpected string payload instead of a normal dictionary. This aligns the process to handle the error in a homogeneous fashion.
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #4928 +/- ##
=======================================
Coverage 77.08% 77.08%
=======================================
Files 44 44
Lines 8549 8549
=======================================
Hits 6590 6590
Misses 1959 1959
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
May 4, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
fixes apache#4926 In rare cases where the query is stopped before it is started, SQL Lab returns an unexpected string payload instead of a normal dictionary. This aligns the process to handle the error in a homogeneous fashion.
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
fixes apache#4926 In rare cases where the query is stopped before it is started, SQL Lab returns an unexpected string payload instead of a normal dictionary. This aligns the process to handle the error in a homogeneous fashion.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
fixes apache#4926 In rare cases where the query is stopped before it is started, SQL Lab returns an unexpected string payload instead of a normal dictionary. This aligns the process to handle the error in a homogeneous fashion.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4926
In rare cases where the query is stopped before it is started, SQL Lab
returns an unexpected string payload instead of a normal dictionary.
This aligns the process to handle the error in a homogeneous fashion.