Hotkeys in SQL Lab #4680
Merged
Hotkeys in SQL Lab #4680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mistercrunch
commented
Mar 23, 2018
•
mistercrunch
commented
Codecov Report
@@ Coverage Diff @@
## master #4680 +/- ##
==========================================
+ Coverage 71.4% 71.59% +0.19%
==========================================
Files 190 191 +1
Lines 14934 14950 +16
Branches 1102 1100 -2
==========================================
+ Hits 10663 10703 +40
+ Misses 4268 4244 -24
Partials 3 3
Continue to review full report at Codecov.
|
|
removed the [WiP] tag, this is ready for review |
hughhhh
reviewed
Mar 26, 2018
| @@ -226,6 +229,32 @@ class SqlEditor extends React.PureComponent { | |||
| render() { | |||
| const height = this.sqlEditorHeight(); | |||
| const defaultNorthHeight = this.props.queryEditor.height || 200; | |||
| const SQLLAB_HOTKEYS = [ | |||
There was a problem hiding this comment.
nit: Can we put this at the top of the file or even in config file for adding new hotkeys more easily. I'm like the idea of a having this separate and we import it
There was a problem hiding this comment.
the actions aren't in scope at that point though...
There was a problem hiding this comment.
Ahhh true, the func param, i just don't like the bulky render view, but if there isn't a way to clean it up we can just go with it.
There was a problem hiding this comment.
moved to this.getHotkeyConfig()
hughhhh
reviewed
Mar 26, 2018
| @@ -196,7 +196,10 @@ export function setDatabases(databases) { | |||
| } | |||
|
|
|||
| export function addQueryEditor(queryEditor) { | |||
| const newQe = Object.assign({}, queryEditor, { id: shortid.generate() }); | |||
| const newQe = { | |||
hughhhh
reviewed
Mar 26, 2018
| <Popover id="popover-hotkeys" title={this.props.header} style={{ width: '300px' }}> | ||
| <Table | ||
| className="table table-condensed" | ||
| data={this.props.hotkeys.map(keyConfig => ({ |
|
🚢 |
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 27, 2018
* Hotkeys * Making it work in AceEditor * Addressing comments
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 30, 2018
* Hotkeys * Making it work in AceEditor * Addressing comments
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 30, 2018
* Hotkeys * Making it work in AceEditor * Addressing comments
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 30, 2018
* Hotkeys * Making it work in AceEditor * Addressing comments
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 30, 2018
* Hotkeys * Making it work in AceEditor * Addressing comments
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 4, 2018
* Hotkeys * Making it work in AceEditor * Addressing comments
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 11, 2018
* Hotkeys * Making it work in AceEditor * Addressing comments
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Hotkeys * Making it work in AceEditor * Addressing comments
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Hotkeys * Making it work in AceEditor * Addressing comments
mistercrunch
added
the
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.