Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coverage] Replacing coveralls with codecov #4533

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Mar 4, 2018

I'm unsure why but coveralls hasn't run as part of the Travis CI since December 2017. It seems nowadays most repos are using codecov rather than coveralls (including incubator-airflow) which is free and requires no token for public GitHub repos and thus I though there was merit in trying to leverage this.

One really nice thing about codecov is they have a browser extension which works seamlessly with GitHub and allows you to see the code coverage right from within GitHub. See here for more details, which includes a demo on YouTube. What's every sweeter, is you can see code coverage of your PR which helps indicate whether you need to write additional unit tests for your change.

Previously coveralls was integrated with tox which meant passing Travis CI environment variables to tox and making the run_tests.sh script aware of whether it was running in a CI environment. Personally I'm not a fan of this interwoven dependency, i.e., I think of tox as a testing environment which can run locally via shell-based testing or with a CI server, and thus should be agnostic of the CI service. Although codecov can also be integrated with tox, given that codecov is primarily a web-based CI tool, personally it makes sense that this is handled completely within Travis CI.

Note this PR produced the following report.

to: @mistercrunch @xrmx

@john-bodley john-bodley force-pushed the john-bodley-replace-coveralls-with-codecov branch from 5bb7450 to 248428e Compare March 4, 2018 21:05
@john-bodley john-bodley changed the title [wip][coverage] Replacing coveralls with codecov [coverage] Replacing coveralls with codecov Mar 4, 2018
@john-bodley john-bodley force-pushed the john-bodley-replace-coveralls-with-codecov branch from 248428e to 4f7258a Compare March 4, 2018 21:26
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@4135854). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #4533   +/-   ##
========================================
  Coverage          ?   71.1%           
========================================
  Files             ?     188           
  Lines             ?   14803           
  Branches          ?    1083           
========================================
  Hits              ?   10525           
  Misses            ?    4275           
  Partials          ?       3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4135854...4f7258a. Read the comment docs.

@mistercrunch
Copy link
Member

This is great. Now we need to figure out how to hook up the JS coverage report.

@mistercrunch
Copy link
Member

LGTM

@john-bodley john-bodley merged commit 71d7196 into apache:master Mar 6, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
…overalls-with-codecov

[coverage] Replacing coveralls with codecov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants