[coverage] Replacing coveralls with codecov #4533
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unsure why but
coveralls
hasn't run as part of the Travis CI since December 2017. It seems nowadays most repos are usingcodecov
rather thancoveralls
(includingincubator-airflow
) which is free and requires no token for public GitHub repos and thus I though there was merit in trying to leverage this.One really nice thing about
codecov
is they have a browser extension which works seamlessly with GitHub and allows you to see the code coverage right from within GitHub. See here for more details, which includes a demo on YouTube. What's every sweeter, is you can see code coverage of your PR which helps indicate whether you need to write additional unit tests for your change.Previously
coveralls
was integrated withtox
which meant passing Travis CI environment variables totox
and making therun_tests.sh
script aware of whether it was running in a CI environment. Personally I'm not a fan of this interwoven dependency, i.e., I think oftox
as a testing environment which can run locally via shell-based testing or with a CI server, and thus should be agnostic of the CI service. Althoughcodecov
can also be integrated withtox
, given thatcodecov
is primarily a web-based CI tool, personally it makes sense that this is handled completely within Travis CI.Note this PR produced the following report.
to: @mistercrunch @xrmx