[Bug] Resize should trigger chart re-render #4322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
approved these changes
Feb 1, 2018
| @@ -87,7 +87,7 @@ class Chart extends React.PureComponent { | |||
| componentDidUpdate(prevProps) { | |||
| if ( | |||
| this.props.queryResponse && | |||
| this.props.chartStatus === 'success' && | |||
| ['success', 'rendered'].indexOf(this.props.chartStatus) > -1 && | |||
There was a problem hiding this comment.
do you think we should make these CONSTANTS to make this less error-prone and ensure consistency between components?
|
I agree we should use enums for this type of things. I'm merging this since it's a high-visibility bug in |
graceguo-supercat
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Feb 1, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is introduced by #4226. Added check for chartStatus == 'rendered'.
@williaster @michellethomas @timifasubaa @mistercrunch