Don't use fully qualified column names in metric definitions #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating an auto SUM() metric on a column, Superset currently will go `SUM(table_name.column_name)`. This is an issue when moving to point to another table. It's common to work on some temporary table or work table and eventually need to point Superset to an alternate table.
|
lgtm |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
…4101) When generating an auto SUM() metric on a column, Superset currently will go `SUM(table_name.column_name)`. This is an issue when moving to point to another table. It's common to work on some temporary table or work table and eventually need to point Superset to an alternate table.
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…4101) When generating an auto SUM() metric on a column, Superset currently will go `SUM(table_name.column_name)`. This is an issue when moving to point to another table. It's common to work on some temporary table or work table and eventually need to point Superset to an alternate table.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating an auto SUM() metric on a column, Superset currently
will go
SUM(table_name.column_name). This is an issue when moving topoint to another table. It's common to work on some temporary table or
work table and eventually need to point Superset to an alternate table.