[Feature] enhanced memoized on get_sqla_engine and other functions #3530
Conversation
Mogball
changed the title
2 similar comments
superset/models/core.py
Outdated
| @@ -590,6 +590,8 @@ def set_sqlalchemy_uri(self, uri): | |||
| conn.password = password_mask if conn.password else None | |||
| self.sqlalchemy_uri = str(conn) # hides the password | |||
|
|
|||
| @utils.memoized( | |||
There was a problem hiding this comment.
The watch is a nice precaution (keep it!), but I think that these attrs wouldn't change during the lifecycle of the ORM instance object. Unless I'm missing something they'd live over a single web request or CLI command and get garbage collected.
There was a problem hiding this comment.
That's what I thought as well, but without watch a good number of unit tests were failing/in error. Though it might just be that the tests modifying attributes instead of creating new objects to set up the tests.
|
Oops merge conflict. Otherwise LGTM. Thanks for following through on this. |
|
Somehow travis is stuck and I cannot merge if the build doesn't pass... Please re-trigger the build by adding a dummy commit on top |
|
Closing/reopening is weird but slightly more reliable :P |
Mogball
changed the title
|
@Mogball if you push stuff to a branch you don't need to close and reopen it to have CI start again, |
2 similar comments
3 similar comments
Mogball
force-pushed
the
mogball/feature/memoized_functions
branch
from
f45b6bb to
3d86da1
Compare
Mogball
force-pushed
the
mogball/feature/memoized_functions
branch
from
3d86da1 to
9e58b89
Compare
|
@mistercrunch Just want to bump this before it falls into oblivion |
…pache#3530) * added watch to memoized * added unit tests for memoized * code style changes
…pache#3530) * added watch to memoized * added unit tests for memoized * code style changes
mistercrunch
added
🏷️ bot
Added
@memoizedto some model functions, i.e.get_sqla_engine()Also modified
@memoizedto take an argumentwatchwhich is a tuple of the names of instance attributes that the decorator should check along with the method arguments.@memoizedwithoutwatchworks as usual.