Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sqllab dont send empty queries to db #3459

Merged
merged 8 commits into from
Sep 14, 2017
Merged

Sqllab dont send empty queries to db #3459

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b3d6e80
add lanscape?
timifasubaa Aug 24, 2017
1ae84f0
Merge branch 'master' of https://github.com/apache/incubator-superset
timifasubaa Aug 29, 2017
4723f2e
prevent empty queries from being sent to db
timifasubaa Sep 13, 2017
55dc463
Revert "add lanscape?"
timifasubaa Sep 13, 2017
28c7513
improve code style
timifasubaa Sep 13, 2017
1cf492a
nit
timifasubaa Sep 13, 2017
7d14512
unnit
timifasubaa Sep 13, 2017
df03355
renit
timifasubaa Sep 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion superset/assets/javascripts/SqlLab/components/SqlEditor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ class SqlEditor extends React.PureComponent {
if (!this.props.database.allow_run_sync) {
effectiveRunAsync = true;
}
this.startQuery(effectiveRunAsync);
if (this.props.queryEditor.sql) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's the right place to add it, maybe an early return at the top of the function instead?

if (!this.props.queryEditor.sql)
    return;

this.startQuery(effectiveRunAsync);
}
}
startQuery(runAsync = false, ctas = false) {
const qe = this.props.queryEditor;
Expand Down