feat(e2e): migrate E2E testing to Playwright, phase 1 #32194
+1,775
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
github-actions
bot
added
the
github_actions
Signed-off-by: hainenber <[email protected]>
… Playwright Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
…est reports Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
…wright E2E migration Signed-off-by: hainenber <[email protected]>
…fade out Signed-off-by: hainenber <[email protected]>
sadpandajoe
reviewed
Feb 13, 2025
| import { setGridMode, clearAllInputs } from '../../utils'; | ||
| import { InterceptItemCategory, setFilter } from '../explore/utils'; | ||
|
|
||
| test.describe('Charts filters', () => { |
There was a problem hiding this comment.
I'd actually like to see these tests removed as they aren't great tests and we should move these over to some kind of component testing that the filters are working
sadpandajoe
reviewed
Feb 13, 2025
| import { setGridMode, clearAllInputs } from '../../utils'; | ||
| import { InterceptItemCategory, setFilter } from '../explore/utils'; | ||
|
|
||
| test.describe('Dashboards filters', () => { |
There was a problem hiding this comment.
same with these filter tests, not sure if there are a lot of value in these sometimes and maybe getting rid of these will help reduce some overhead we have now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(e2e): migrate E2E testing to Playwright
SUMMARY
Part of Superset megaproject to lessen pain points from existing Cypress-based E2E testing suites. This PR is 1 of many phases:
I'd leave the PMCs to handle the Applitools test suites as currently I am not permitted to do so.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION