Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ScreenshotCachePayload serialization #32156

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

betodealmeida
Copy link
Member

SUMMARY

Change the serialization of ScreenshotCachePayload, since it doesn't work across all cache backends. The new implementation serializes the object into a dictionary of attributes.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Feb 5, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@github-actions github-actions bot added the api Related to the REST API label Feb 5, 2025
@sadpandajoe
Copy link
Member

@michael-s-molina would be good if we can cherry this in also for part of 5.0rc2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the REST API size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants