Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: No virtual environment when running Docker translation compiler #32133

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR fixes the following error triggered by the Docker translation compiler step:

failed to solve: process "/bin/sh -c /app/docker/pip-install.sh --requires-build-essential 
-r requirements/translations.txt" did not complete successfully: exit code: 2

The root cause can be verified in the Docker build logs:

error: No virtual environment found; run `uv venv` to create an environment, or pass `--system` 
to install into a non-virtual environment

This PR makes sure that the virtual environment created by

RUN uv venv /app/.venv

is activated before invoking pip-install.sh.

TESTING INSTRUCTIONS

Run docker compose build and check that the process runs successfully.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Documentation
Logging
Error Handling
Readability and Maintainability
Design Patterns
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit 53d944d into apache:master Feb 4, 2025
46 checks passed
@michael-s-molina michael-s-molina added the v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch label Feb 4, 2025
michael-s-molina added a commit that referenced this pull request Feb 4, 2025
@EmmanuelCbd
Copy link

Thank you @michael-s-molina , I spent time since monday to fix this issue.
Great job.

@EmmanuelCbd
Copy link

@michael-s-molina , I've recompiled the docker image with latest commits on master, but still no .mo files in translations folders.
When I run it and have a look in the folders, there's only the .json files.
I edited the Dockerfile to comment the removal of .po and tryed to run the pybabel command, afterward, but I'm logged with superset user and can't su/sudo.
And yes, I have also set BUILD_TRANSLATIONS to "true" :)

Does it work for you ?

@michael-s-molina
Copy link
Member Author

@EmmanuelCbd Could you open a new issue and tag @mistercrunch @rusackas @sadpandajoe? They know more about translations than me and @mistercrunch recently modified related files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants